Koozali.org: home of the SME Server

Synching coding constructs

Offline apmuthu

  • *
  • 244
  • +0/-0
Synching coding constructs
« on: February 25, 2013, 09:28:57 AM »
File : /opt/sark/generator/srktimer.php

In SAIL v3.1.0-145, a variable $debug with same error message at each failure is echo-ed out.
In SAIL v3.1.1-22 / v4.0.0-43, the try()/CATCH exception() construct is used.

Synchronising the generator files across versions would make for easy troubleshooting and uniformity of coding style.

Assume that since 3.1.0 is too old, no patches are being done.

« Last Edit: February 25, 2013, 10:00:06 AM by apmuthu »

Offline SARK devs

  • ****
  • 2,806
  • +1/-0
    • http://sarkpbx.com
Re: Synching coding constructs
« Reply #1 on: February 26, 2013, 01:46:14 AM »
Hi

$debug is used in 3.1.0/3.1.1/4.0.0 but only in perl code (with the exception of the php srktimer routine in 3.1.1, which you've seen and which was dropped in 4.0.0). 

try/catch is used in the generator php code but only for SQL call errors. 

The generator code was rewritten from perl to php in 3.0.  I just did a diff on the 3.1.0 generator vs 4.0.0 generator and there are maybe 50 lines of code different, so its been pretty stable, particularly when that includes the change to dynamic queues/agents.

3.1.0 is too old to do general patching now, although we will occasionally make changes for active customers; we still have a lot on -145, it was a pretty good release.

Best

S

Offline apmuthu

  • *
  • 244
  • +0/-0
Re: Synching coding constructs
« Reply #2 on: February 26, 2013, 03:40:14 PM »
Thanks for the info Jeff. It would be nice to have the last stable release with all patches to date in the SAIL distribution area so that if there are any users who find workarounds / bugs / fixes, they will benefit the community. A case in point would be the last stable distribution for a vanilla CentOS install and another that did not need DAHDI drivers to work - DAHDI v2.3.0 was the last stated series to allow that.