Updated this Contrib from a previous Contrib.
In summary
All required RPM’s are in one RPM. (Perhaps there is better way? yum)
Hints:
-Don't package all those RPM's inside this RPM. Give your RPM the proper requires and let yum figure out the dependancies. This method will install the correct needed dependancies with up to date centos versions. This will also drop the size of your RPM to a few hundred KB. It will also do the proper thing when it comes time to remove your package.
-Don't put templates included in your RPM in the templates-custom directory, put them in the templates directory.
-Don't use chmod on the templates, use templates.metadata to set pemissions if needed.
-Don't set permissions on templates any higher than needed. I don't think any of the templates included in this RPM need anything more than 644. (template fragments don't generally need to be executable and 755 is most likely too permissive).
-The template under /etc/samba/smb.conf may not be correct, that directory doesn't exist and that template is doubled up under /etc/smb.conf.
-I don't know if the method used to create the ibay is correct. You may want to use the db and events whenever possible (eg. set ibay properties in the db and use "signal-event ibay-create")
-Get rid of the uninstall.sh script. You should write you package so that yum does everything for you.
I'm sure there are more tips. I suggest you read the deveoper's guide found here:
http://mirror.contribs.org/smeserver/contribs/gordonr/devguide/html/devguide.html